Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard Accessible MenuItems and VolumeMenuButton #1519

Merged
merged 3 commits into from
Sep 30, 2014
Merged

Keyboard Accessible MenuItems and VolumeMenuButton #1519

merged 3 commits into from
Sep 30, 2014

Commits on Sep 19, 2014

  1. Changed the MenuItem and the Volume Control bar to gain focus when us… 

    …ing tab navigation.

Previously, they could not be navigated to via the keyboard.
Fixs #1517.
Tested via manaul cross-browser tests using keyboard navigation (chrome, firefox, safari, and IE 11 ).
    Ryan Plessner committed Sep 19, 2014
    Configuration menu
    Copy the full SHA
    53d690c View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2014

  1. reverted the submenu behavior. it now needs to activated before it me… 

    …nuitems become tab targets. The volume control bar now uses the vjs-lock-showing class instead of new class.
    Ryan Plessner committed Sep 23, 2014
    Configuration menu
    Copy the full SHA
    757c592 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2014

  1. Hide the volume bar by setting its content's width to zero.

    Ryan Plessner committed Sep 25, 2014
    Configuration menu
    Copy the full SHA
    f53583e View commit details
    Browse the repository at this point in the history