Audio Support #1540
Closed
Audio Support #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,9 @@ vjs.PosterImage = vjs.Button.extend({ | |||
| this.src(player.poster()); | |||
| })); | |||
|
|
|||
| player.on('play', vjs.bind(this, this.hide)); | |||
| if (!player.isAudio()) { | |||
There was a problem hiding this comment.
keep the poster showing if not audio, right?
There was a problem hiding this comment.
No, keep the poster showing if it is audio. The thought being you could put album art or something and it would be more interesting than a black frame.
There was a problem hiding this comment.
er, yeah, that's what I meant. Idk where that not camre from.
mmcc
force-pushed
the
feature/audio-support
branch
2 times, most recently
from
12cea88
to
6ebbc1b
Compare
mmcc
force-pushed
the
feature/audio-support
branch
from
6ebbc1b
to
5ce3d0f
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some basic changes to make VJS work a little better out of the box for audio support.