Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Sauce Labs browsers #2149

Closed
wants to merge 7 commits into from
Closed

Conversation

forbesjo
Copy link
Contributor

This change is to:

  • Remove 'singleRun' duplicates
  • Use latest default Sauce Labs browsers
  • Not start Sauce Connect again, it should have started in .travis.yml before script

@heff
Copy link
Member

heff commented May 13, 2015

Awesome, thanks Joe. If we just left off the device and platform versions, would it use the latest ones? It'd be nice to not have to manually update this as versions increase.

@forbesjo
Copy link
Contributor Author

I simplified the browser capabilities some more, right now IE will default to Win7 - IE11 and Android will default to latest. Only iOS and Safari need versions or else they will default to iOS 5 and Safari for Windows.

I'm also not able to get the iOS and Android tests to run so I am skipping them for now.

@heff
Copy link
Member

heff commented May 13, 2015

Nice, thanks.

they will default to iOS 5 and Safari for Windows.

😠

I'm also not able to get the iOS and Android tests to run so I am skipping them for now.

😞 Yeah I saw Android pass once but Bootstrap skips them all together because the platform is flaky. I couldn't get iOS to run either. We should test on read devices to make sure there isn't a problem there.

@forbesjo
Copy link
Contributor Author

I bumped up the timeouts from 1min to 5 and got the Android tests to pass. The iOS tests at least start but seem to hang half way through.

When I view the qunit page in the simulators/emulators on Sauce Labs they pass. Also just checked on real devices and they pass too.

@cvrebert
Copy link
Contributor

The automated Sauce Labs test's screencast should give some indication of which individual testcase it's getting hung up on.

@forbesjo
Copy link
Contributor Author

Instead of dealing with karma being weird I decided to swap in grunt-saucelabs. The iOS and Android tests pass now but IE and Firefox on Linux are timing out. I'll see if I can figure out the issues.

@heff
Copy link
Member

heff commented May 13, 2015

The iOS and Android tests pass now but IE and Firefox on Linux are timing out

e70639958fe1f60ffe3a17f643d2cad9 jpg

@heff heff mentioned this pull request May 18, 2015
@heff
Copy link
Member

heff commented May 18, 2015

I just got an email that Sauce Connect 3 is being EOL'd for Connect 4. Are we already using 4?

Also I really hope their logo now includes this some how...
5103f3dhq0l sy300
(I want to feel like the kid on the left but right now Sauce makes me feel like the kid on the right)

@forbesjo
Copy link
Contributor Author

3.1 is being used in .travis.yml. We can have saucelabs-qunit run Sauce Connect 4 by setting tunneled to true and removing the shell script line. Bootstrap and Winjs do this.

@heff
Copy link
Member

heff commented May 18, 2015

Any guesses on if that will help with some of the issues we've seen?

@forbesjo
Copy link
Contributor Author

IE seems to be working now, I don't know if it is related to SC 4 though. Firefox on any platform refuses to work, I'll leave that for a future fix.

@heff
Copy link
Member

heff commented Jun 10, 2015

@forbesjo I asked @gkatsev to give a final review, then we'll pull in.

@@ -9,7 +9,33 @@
<body>
<div id="qunit"></div>
<script src="../node_modules/qunitjs/qunit/qunit.js"></script>

<script type="text/javascript">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do exactly?

(Also, technically, the type isn't necessary in scripts anymore :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows you to see the test results in Sauce Labs.
https://saucelabs.com/tests/68dcb9204fb94091996679fa2299f054

Should I just put this in globals-shim.js?

@gkatsev
Copy link
Member

gkatsev commented Jun 10, 2015

LGTM

@cvrebert
Copy link
Contributor

cvrebert commented Jul 8, 2015

Slightly tangential, but you might want to consider switching from Sauce Labs to a different Selenium provider. See theintern/intern#394
(Savage will still work, you'll just need to encrypt the new credentials.)

@forbesjo
Copy link
Contributor Author

forbesjo commented Jul 8, 2015

I also found Browserstack to be more stable. HLS videos seem to not work in Sauce Labs OS X but work fine in Browserstack so it might be something to look into.

@heff
Copy link
Member

heff commented Jul 9, 2015

How complicated would the switch be for us? @cvrebert have you tried out intern? Is that something we should look into using?

@cvrebert
Copy link
Contributor

cvrebert commented Jul 9, 2015

I have not used intern personally, although it sounds promising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants