Enhanced EventEmitter to pass data with an event. fixes #1979 #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome stuff. |
| @@ -53,7 +53,7 @@ export function on(elem, type, fn){ | |||
| if (event.isImmediatePropagationStopped()) { | |||
| break; | |||
| } else { | |||
| handlersCopy[m].call(elem, event); | |||
| handlersCopy[m].apply(elem, [event].concat(evtData)); | |||
There was a problem hiding this comment.
I think you should be able to do something like
handlersCopy[m].call(elem, event, ...evtData);
There was a problem hiding this comment.
@carpasse did you want to update these to match the single hash arg or are you happy with it as is? Other than this question I think it's good to pull in.
There was a problem hiding this comment.
@heff I did update them 3 days ago. I don't know why they are not shown here.
Can you please take a look a the changes in master...carpasse:feature/event-emitter-enhance
| */ | ||
| export function trigger(elem, event) { | ||
| export function trigger(elem, event, ...evtData) { | ||
| // Fetches element data and a reference to the parent (for bubbling). |
|
@heff My bad. I did miss one 'rest' argument in the 'on' method dispatcher. It should be fixed now. |
|
No worries. Looks good to me. I'll merge in soon. |
|
Finally got this merged in. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended trigger function to pass the data to the event handlers