Add poster to the options the tech are receiving #2338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only way I can know if I must set the default YouTube poster is by checking if the option poster is already set. However, that information is not sent to the tech right now.
|
Makes sense to me. Does the video.js poster not cover up the youtube poster? |
|
The tech needs to set the YouTube poster url. If we use the one displayed by the iframe, we have a big red ugly play button (really weird with the vjs poster). When we set a VJS poster, it hides the whole iframe until you click play. |
| @@ -502,7 +502,8 @@ class Player extends Component { | |||
| 'autoplay': this.options_.autoplay, | |||
| 'preload': this.options_.preload, | |||
| 'loop': this.options_.loop, | |||
| 'muted': this.options_.muted | |||
| 'muted': this.options_.muted, | |||
| 'poster': this.options_.poster | |||
There was a problem hiding this comment.
@eXon could you change this to use this.poster()? That would make sure that if the poster changes, later techs will get the new poster.
|
Merged in, thanks! I think we still have a little to figure out around the poster in #2339. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only way I can know if I must set the default YouTube poster is by checking if the option poster is already set. However, that information is not sent to the tech right now.