Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bubble tech events by default #2351

Closed
wants to merge 1 commit into from

Conversation

dmlap
Copy link
Member

@dmlap dmlap commented Jul 13, 2015

The majority of media events are simple events, which mean they don't bubble. Switch the default event behavior to not bubble to match this at the base tech level.

@pam
Copy link

pam commented Jul 13, 2015

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: b14342b
Build details: https://travis-ci.org/pam/video.js/builds/70822565

(Please note that this is a fully automated comment.)

@heff
Copy link
Member

heff commented Jul 14, 2015

I thought the last thing we said in chat was to default the whole events system to not bubble by default.
https://github.com/videojs/video.js/blob/master/src/js/utils/events.js#L164
&& bubbles === true.

All events will not bubble unless event.bubbles is strictly true.
@pam
Copy link

pam commented Jul 21, 2015

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: c8d5dcf
Build details: https://travis-ci.org/pam/video.js/builds/71970416

(Please note that this is a fully automated comment.)

@pam
Copy link

pam commented Jul 21, 2015

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: dac044c262834e1fb0bd5936f8d2e3d2b45c8414
Build details: https://travis-ci.org/pam/video.js/builds/71970345

(Please note that this is a fully automated comment.)

@heff
Copy link
Member

heff commented Jul 21, 2015

LGTM! Merged.

@dmlap dmlap deleted the simple-events-do-not-bubble branch July 21, 2015 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants