Restore novtt version of VideoJS #2447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The novtt version of VideoJS was not being created (though there was a `copy` task for it). This restores it and moves the generation of banners out of the browserify process so that the license banner can be programmatically generated depending on the presence of vtt.js. - Lodash is pulled into the Gruntfile, but it was already a dependency. - License banner templates are processed by customized processor functions, which manually render.
|
lgtm |
|
LGTM |
| options: { | ||
| separator: '\n' | ||
| }, | ||
| src: ['build/temp/video.js'], |
There was a problem hiding this comment.
We're not actually concatenating anything here, but works for me. :)
|
fwiw, I don't think the separate license header for vtt is really necessary, but nicely done either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The novtt version of VideoJS was not being created (though there was a
copytask for it). This restores it and moves the generation of banners out of the browserify process so that the license banner can be programmatically generated depending on the presence of vtt.js. Relevant changes are: