Remove a bunch of code that tried to disable tracks by default #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nope, looks like there aren't any tests for this that need to be removed. |
|
Have we confirmed if this issue is fixed in Chrome? I got the impression it might at least be fixed in Canary. And fwiw, the captions still showed for me in desktop safari, even with the fix we're removing here. So if Chrome is fixed, not a huge impact I don't think. lgtm |
|
I'll see exactly where it is fixed, it'll be good to document. However, I still think this is the right move, for better or worse. |
|
Also fixes #2436. |
|
still lgtm |
|
👍 |
|
Looks like stable chrome still shows tracks by default. |
gkatsev
added a commit
to gkatsev/video.js
that referenced
this pull request
Aug 21, 2015
|
It's merged. a02f0be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that's all of it (plus probably some tests that are forthcoming).
I'll open it against master soon.