Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vertical slider to have auto left/right margins #2943

Closed
wants to merge 1 commit into from
Closed

update vertical slider to have auto left/right margins #2943

wants to merge 1 commit into from

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Dec 22, 2015

Fixes #2942.

@dmlap
Copy link
Member

dmlap commented Dec 22, 2015

I don't see anything wrong with this PR but I was fooled last time. As long as you've checked it thoroughly, LGTM

@gkatsev
Copy link
Member Author

gkatsev commented Dec 22, 2015

Here's a pic:

@gkatsev
Copy link
Member Author

gkatsev commented Dec 22, 2015

Worst case, we patch it again!

@gkatsev gkatsev closed this in 6926082 Dec 22, 2015
@gkatsev gkatsev deleted the fix-vertical-volume-bar-again branch March 8, 2016 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkatsev @dmlap