Do not autoplay if there is no source

[forbesjo]

This PR prevents the player from calling play() with autoplay and no source. In Firefox this would fire a 'play' event (See http://jsbin.com/vubugev/edit?html,console,output). For some reason this doesn't happen in Chrome.

[gkatsev]

We probably should make sure that when a source is then added it'll get autoplayed. Does this happen in your testing? We may or may not want to have a similar check inside of player#src

[forbesjo]

setSrc() in the Flash tech does check for autoplay and calls play(). The HTML tech just lets the video element deal with it. I've checked and after I call src() the video does automatically play.

[forbesjo]

@gkatsev wondering if you have any more comments on this one.

[gkatsev]

LGTM.
We probably should have a story at some point about fixing autoplay completely.

[jamesgorrie]

The problem with this seems to be that if I have specified <source src="../thing.m3u8" type="video/m3u8"> player.src() is then "" (or !). Is this a bug when setting src? If so I can file it.

[gkatsev]

video/m3u8 isn't a correct mimetype for m3u8/HLS content.

[jamesgorrie]

Apologies (And thanks for the heads up).

We are supplying multiple sources, and even when only serving the mp4 content we don't see the player.src() populated. Only when we add the src attribute to the video element itself.

e.g. of video element:

Not working

<video class="vjs-tech" preload="auto" aria-hidden="true">
  <source src="https://example.com/example.mp4" type="video/mp4">                
</video>

Working

<video class="vjs-tech" preload="auto" aria-hidden="true" src="https://example.com/example.mp4">
  <source src="https://example.com/example.mp4" type="video/mp4">                
</video>

[gkatsev]

Can you open a separate issue for this? Thanks.

[gkatsev]

Also, if you can include a working test case on a site like jsfiddle, that would be best.

[jamesgorrie]

Okay - after quite a bit of digging, it appears it has to do with the fact that, if a page is loaded, we have a currentSrc set.

This then doesn't run the setSrc function as the current.src === this.el_.src

So either this PR should include:

if ((this.src() || this.currentSrc()) && this.tag && this.options_.autoplay && this.paused()) {
//...
}

Or the setSrc method should be updated.

Here is an example where autoplay won't work when we have currentSrc set from the browser.

[jamesgorrie]

Created an issue here #3071