Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to timeupdate on waiting #3138

Closed
wants to merge 2 commits into from
Closed

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Feb 24, 2016

Description

This is to workaround a bug currently present in IE11 and potentially in
other cases where we get the waiting event and set the vjs-waiting
class on the player which shows the spinner but then we don't get any
of the events that we use to remove the spinner.
This fixes #3124.

Specific Changes proposed

Inside of handleTechWaiting_, listen to the first timeupdate event to clear the vjs-waiting class from the player.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by One Core Contributors

This is to workaround a bug currently present in IE11 and potentially in
other cases where we get the waiting event and set the vjs-waiting
class on the player which shows the spinner but then we don't get any
of the events that we use to remove the spinner.
This fixes videojs#3124.
@gkatsev gkatsev added patch This PR can be added to a patch release. needs: LGTM Needs one or more additional approvals labels Feb 24, 2016
@dmlap
Copy link
Member

dmlap commented Feb 26, 2016

Should we have a test for this? (Actual question)

@gkatsev
Copy link
Member Author

gkatsev commented Feb 26, 2016

I can try adding one.

@gkatsev
Copy link
Member Author

gkatsev commented Mar 2, 2016

@dmlap I added a simple test.

@dmlap
Copy link
Member

dmlap commented Mar 3, 2016

LGTM

@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels Mar 7, 2016
@gkatsev gkatsev closed this in f77bcc9 Mar 7, 2016
@gkatsev gkatsev deleted the ie11-waiting branch March 8, 2016 20:38
@mctep
Copy link

mctep commented Apr 5, 2016

Hello! Thank you for your job.

May be it is better to trigger canplay event in html5 tech only for IE11 after waiting and timeupdate?

In my case I use https://github.com/google/shaka-player and it triggers timeupdate right after bufferingStart event. And spinner works incorrect after this fix. So I need to trigger waiting event in next tick:

class ShakaTech extends Tech {
 constructor() {
  // ...
  shakaPlayer.on('bufferingStart', () => {
    setTimeout(() => this.trigger('waiting'));
  })
  // ...
 }
}

It is not big problem. But I think it is not consistent and not obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE11 - currenTime() and waiting wheel problem
3 participants