Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the relative routes for easy compilation #3147

Closed
wants to merge 1 commit into from
Closed

Change the relative routes for easy compilation #3147

wants to merge 1 commit into from

Conversation

ricardosiri68
Copy link
Contributor

Description

Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

changing the route to videojs-font this way don't crash when i try to import the scss module

changing the route to `videojs-font` this way don't crash when i try to import the scss module
@gkatsev
Copy link
Member

gkatsev commented Feb 29, 2016

so sass always runs relative to the root/where it's run from? Interesting...

@gkatsev gkatsev added patch This PR can be added to a patch release. needs: LGTM Needs one or more additional approvals minor This PR can be added to a minor release. It should not be added to a patch release. and removed patch This PR can be added to a patch release. labels Mar 3, 2016
@gkatsev
Copy link
Member

gkatsev commented Mar 14, 2016

@videojs/core-committers anyone else care to do a code review?

@nickygerritsen
Copy link
Contributor

We have had a similar issue in a completely different project and solved it in a similar way.
So I guess LGTM

@gkatsev
Copy link
Member

gkatsev commented Mar 14, 2016

Thanks @nickygerritsen.

@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels Mar 14, 2016
@gkatsev gkatsev closed this in bf95bb2 Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed minor This PR can be added to a minor release. It should not be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants