Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty menu throws an error when it gets focus (Rebase to stable branch) #3218

Closed
wants to merge 3 commits into from
Closed

Fix empty menu throws an error when it gets focus (Rebase to stable branch) #3218

wants to merge 3 commits into from

Conversation

llun
Copy link

@llun llun commented Mar 29, 2016

Description

When empty menu get focus without any children cause it throws an error. (Link to previous pr)

Specific Changes proposed

  • Add children checking in menu focus before check the title

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@llun llun mentioned this pull request Mar 29, 2016
Closed
6 tasks
@llun llun changed the title Stable Fix empty menu throws an error when it gets focus (Rebase to stable branch) Mar 29, 2016
@gkatsev gkatsev added patch This PR can be added to a patch release. needs: LGTM Needs one or more additional approvals labels Mar 29, 2016
@gkatsev
Copy link
Member

gkatsev commented Mar 29, 2016

Thanks! LGTM

@misteroneill
Copy link
Member

LGTM as well 👍

@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels Mar 29, 2016
@gkatsev gkatsev closed this in 31b2f9d Mar 29, 2016
@gkatsev
Copy link
Member

gkatsev commented Mar 29, 2016

@llun thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llun @gkatsev @misteroneill