Audio button #3223
Closed
Audio button #3223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import * as Fn from '../../utils/fn.js'; | ||
| import AudioTrackMenuItem from './audio-track-menu-item.js'; | ||
|
|
||
| class AudioTrackButton extends MenuButton { |
There was a problem hiding this comment.
what about having this button extend TrackButton and refactor TextTrackButton into a TrackButton? it already does the removetrack addtracker listening.
There was a problem hiding this comment.
Sounds like a good idea.
2 tasks
forbesjo
force-pushed
the
audio-button
branch
3 times, most recently
from
c7f6d6e
to
6f80d79
Compare
Added audio icon Extract TrackButton from Audio and TextTrack buttons Add document comments
| */ | ||
| class AudioTrackButton extends TrackButton { | ||
| constructor(player, options = {}) { | ||
| options.tracks = player.audioTracks && player.audioTracks(); |
There was a problem hiding this comment.
yes, it is, in the TrackButton, missed it.
gkatsev
added
minor
| items.push(new AudioTrackMenuItem(this.player_, { | ||
| // MenuItem is selectable | ||
| 'selectable': true, | ||
| 'track': track |
There was a problem hiding this comment.
This object literal could be simplified to:
{
track,
selectable: true
}There was a problem hiding this comment.
To elaborate, I feel like we should start writing code that will pass the video.js linter even if the project at large won't pass it.
|
LGTM |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an audio button for audio track selection. It depends on
videojs/font#13and#3137