Set lang="en" on the <html> tag in HTML files. #3257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
Yeah LGTM |
|
@OwenEdwards how do you feel about trying to merge this in yourself? I know the contributing guide isn't great but I can let you know how it's done if you're up for it. |
|
@gkatsev okay, how about we connect about this on Wednesday? |
|
@OwenEdwards sounds good. I want to spread the merging ability to people who aren't just me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set the lang attribute on all tags in HTML files (in /sandbox/ and /test/).
Specific Changes proposed
This is required for accessibility compliance, and will prevent these errors being reported by accessibility testing tools.
Requirements Checklist