null out currentSource_ on tech dispose and src change #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -813,6 +813,8 @@ Tech.withSourceHandlers = function(_Tech){ | |||
| // than clear all of our current tracks | |||
| if (this.currentSource_) { | |||
| this.clearTracks(['audio', 'video']); | |||
There was a problem hiding this comment.
@brandonocasey is there a reason why we don't want to just always call clearTracks() here?
There was a problem hiding this comment.
I'm not sure I entirely remember but I think it had to do with saving keeping Audio/Video Tracks that were added before we had a currentSource
There was a problem hiding this comment.
Ok, I'll see what I can find out. Currently, the tests break because of this.
There was a problem hiding this comment.
Ended up removing clearing out the currentSource_ in disposeSourceHandler and only doing it inside this if statement.
|
Looks good to me |
gkatsev
added
patch
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3285, we need
currentSource_to be cleared out if we're switching sources on a tech and we're no longer using a source handler. Plus, when the tech is disposed, we should clear out thecurrentSource_.