Improve Logging for IE < 11 #3356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
added
enhancement
minor
|
Can you add a test for the JSON.stringify functionality? |
IE11 introduced expandable objects in the console. Previously, everything was .join()ed and, therefore, objects came through as "[object Object]", which is not useful. This improves the ES6-ification of the log module and passes objects and arrays through JSON.stringify before logging them in IE10 and lower. Some opportunities for ES6 brevity were left out because JSHint does not like them; though, they would pass videojs-standard.
misteroneill
force-pushed
the
better-ie-logging
branch
from
adb1a69
to
9681f18
Compare
|
You're right. 😄 I added a test for that behavior. Unfortunately, it meant exposing the Rebased on |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IE11 introduced expandable objects in the console. Previously, everything was
.join()ed and, therefore, objects came through as[object Object], which is not useful. This improves the ES6-ification of the log module and passes objects and arrays throughJSON.stringify()before logging them in IE10 and lower.Some opportunities for ES6 brevity were left out because JSHint does not like them; though, they would pass
videojs-standard.Specific Changes proposed
utils/logmodule.Requirements Checklist