Linter v5 Compatibility #3478
Merged
Linter v5 Compatibility #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
added
the
minor
misteroneill
added
needs: LGTM
| @@ -3015,10 +3015,10 @@ Player.prototype.handleVolumeChange_; // eslint-disable-line | |||
| * | |||
| * @event error | |||
| */ | |||
| Player.prototype.handleError_ = Player.prototype.handleError_; | |||
| Player.prototype.handleError_; // eslint-disable-line | |||
There was a problem hiding this comment.
how does this work and is it needed? seems like it is never used from a quick code search
There was a problem hiding this comment.
it's used for the jsdoc @event comment.
|
LGTM other than my small comments |
| @@ -1452,7 +1452,7 @@ class Component { | |||
| subObj.extend = Component.extend; | |||
|
|
|||
| // Extend subObj's prototype with functions and other properties from props | |||
| for (let name in props) { | |||
| for (const name in props) { | |||
There was a problem hiding this comment.
are you sure this shouldn't be a let?
|
I guess |
gkatsev
added
confirmed
and removed
needs: LGTM
|
Yeah, ESLint complains about it. Which makes some sense, I suppose. |
misteroneill
force-pushed
the
vjsstandard-core
branch
from
deddb6b
to
caf614e
Compare
misteroneill
force-pushed
the
vjsstandard-src-v5
branch
from
64b79cc
to
e22aca9
Compare
misteroneill
added a commit
to misteroneill/video.js
that referenced
this pull request
Aug 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes the source code pass v5 of videojs-standard.
Requirements Checklist