-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide controls and cursor on inactivity. fixes #333, fixes #374, fixes #3 #403
Conversation
I'm not sure if hiding cursor in normal screen mode is a good idea, it could disorient the user i guess. Would love some input on this issue. |
This is a good start. #193 I believe addresses this too and it might be good to check that out. As far as normal vs. fullscreen, this is the typical behavior I see: I'd like to have @gkatsev weigh in since he's been working on the mobile controls. |
There are still a couple of problems im not quite sure how to address:
this.player_.trigger('mousemove'); But no luck. Is this supposed to work? Am i missing something? |
This change currently does not affect any of the mobile/touch devices. For mobile, we probably want to have auto-hiding controls, at least when in full-screen, specifically, if it doesn't use the native players. |
Where we have seen legitimate need for hiding controls is with popovers, or galleries, which open from a thumbnail, and display the player. Since the viewer in these instances has already clicked, they should expect the video to open and start to play. Further, when the video begins to play, they should not expect to have to move their cursor back over the player to get the controls to disappear. Anytime after video starts to play, where controls are initially hidden, should the viewer move their cursor over the player, the controls should appear, but then disappear again if the cursor is moved outside the player. |
Any chance we can get the merge conflicts resolved on this one? |
I think this is a simple solution to a very common problem of not fully being able to enjoy your favourite movie/tv-show/whatever because of unhidable controls and mouse, especially in fullscreen.