Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spinner position. #694

Merged
merged 1 commit into from
Aug 27, 2013
Merged

Fix spinner position. #694

merged 1 commit into from
Aug 27, 2013

Conversation

ChALkeR
Copy link
Contributor

@ChALkeR ChALkeR commented Aug 19, 2013

This commit fixes spinner position that is otherwise broken in some environments.

@ChALkeR
Copy link
Contributor Author

ChALkeR commented Aug 19, 2013

Actually, the spinner is mispositioned without this fix if the video is placed inside «text-align:center» enviroment.

@heff
Copy link
Member

heff commented Aug 19, 2013

I think I like this approach since it directly addresses the problem on the spinner element. I was telling @mmcc that it'd be nice to change all text alignment on the entire skin to centered, because that's what's used the most. This change I think would help us do this.

Have you had a chance to test this in other browsers, like IE8?

@heff heff merged commit 2f68bfc into videojs:master Aug 27, 2013
@heff
Copy link
Member

heff commented Aug 27, 2013

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants