This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
always activate loading in segment loaders after a seek #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjneil
commented
Aug 14, 2017
test/videojs-contrib-hls.test.js
Outdated
| @@ -2780,7 +2780,7 @@ QUnit.test('cleans up the buffer when loading VOD segments', function(assert) { | |||
| this.clock.tick(1); | |||
| this.player.currentTime(120); | |||
| this.player.tech_.hls.mediaSource.sourceBuffers[0].trigger('updateend'); | |||
| this.clock.tick(1); | |||
| this.clock.tick(2); | |||
There was a problem hiding this comment.
This change was needed because previously, after an updateend event, SegmentLoader.handleUpdateEnd_ would call SegmentLoader.monitorBuffer_ which would setup a timeout to call SegmentLoader.fillBuffer_ on the next clock tick, but with the addition of calling load on a seek, this would clear that timeout and set a new one for the next clock tick.
There was a problem hiding this comment.
This would be good to add as a comment above the clock tick (since clock ticks are generally pretty mysterious through our tests).
gesinger
reviewed
Aug 15, 2017
test/videojs-contrib-hls.test.js
Outdated
| @@ -2780,7 +2780,7 @@ QUnit.test('cleans up the buffer when loading VOD segments', function(assert) { | |||
| this.clock.tick(1); | |||
| this.player.currentTime(120); | |||
| this.player.tech_.hls.mediaSource.sourceBuffers[0].trigger('updateend'); | |||
| this.clock.tick(1); | |||
| this.clock.tick(2); | |||
There was a problem hiding this comment.
This would be good to add as a comment above the clock tick (since clock ticks are generally pretty mysterious through our tests).
gesinger
approved these changes
Aug 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the video has
endedthe player goes into a paused state. If you try and seek anywhere in the video after this, the player is still paused, so theSegmentLoaders do not being loading again. This results in the user seeing a loading spinner and black screen until they hit play. What should happen is the player begins loading segments at the new seek position and append to the buffer so the first frame of the position is displayed.