Xdmf compilation error

[jfavre]

compiling the Xdmf reader with gcc-12, I run into this error and am surprised I could not find any previous discussion on the topic:

[ 2%] Building CXX object libsrc/CMakeFiles/Xdmf.dir/XdmfDsmComm.o
/run/user/1100/VisIt/visit3.4.1/Xdmf/libsrc/XdmfDsmComm.cxx: In member function ‘virtual XdmfInt32 XdmfDsmComm::Receive(XdmfDsmMsg*)’:
/run/user/1100/VisIt/visit3.4.1/Xdmf/libsrc/XdmfDsmComm.cxx:53:18: error: ordered comparison of pointer with integer zero (‘void*’ and ‘int’)
53 | if(Msg->Data <= 0 ){
| ~~~~~~~~~~^~~~
/run/user/1100/VisIt/visit3.4.1/Xdmf/libsrc/XdmfDsmComm.cxx: In member function ‘virtual XdmfInt32 XdmfDsmComm::Send(XdmfDsmMsg*)’:
/run/user/1100/VisIt/visit3.4.1/Xdmf/libsrc/XdmfDsmComm.cxx:67:18: error: ordered comparison of pointer with integer zero (‘void*’ and ‘int’)
67 | if(Msg->Data <= 0 ){

[markcmiller86]

@jfavre sorry you ran into this. I see we have patches for Xdmf lib itself in bv_xdmf.sh to fix the lib for this exact issue. I dunno why we have plugin code that has this issue.

[jfavre]

from the build_visitl_log:

library xdmf depends on cmake vtk hdf5 zlib
Building Xdmf (~2 minutes)
prepare_build_dir: Xdmf Xdmf-2.1.1.tar.gz
Unzipping/Untarring Xdmf-2.1.1.tar.gz . . .
Patching Xdmf . . .
patching file Xdmf/libsrc/XdmfValuesBinary.cxx
-- Performing Test Xdmf support for 64 bit file systems
-- Performing Test Xdmf support for 64 bit file systems - Success

I see that the apply_xdmf_gcc_11_2_patch is not getting applied, because [[ "$C_COMPILER" == "gcc" ]] evaluates to false (my compiler is called "gcc-12"; see above, I used the --cc option)

[JustinPrivitera]

All I was saying is that you can remove --vtk from ./src/tools/dev/scripts/build_visit --cc /usr/bin/gcc-12 --cxx /usr/bin/g++-12 --no-visit --parallel --llvm --mesagl --vtk --vtk9 --makeflags -j16 --system-python --qwt --qt --silo --hdf5 --system-cmake --icet --ospray --ispc --embree --tbb --mfem --conduit --xdmf

You don't need to specify both --vtk and --vtk9

[markcmiller86]

I see that the apply_xdmf_gcc_11_2_patch is not getting applied, because [[ "$C_COMPILER" == "gcc" ]] evaluates to false (my compiler is called "gcc-12"; see above, I used the --cc option)

@jfavre ok, we'll take a look at that logic. In the mean-time, as you've probably already figured out, you can work-around this by forcing it yourself by hacking the build_visit code.

[markcmiller86]

FYI...See #19693