Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test to use new ddf api #18683

Merged
merged 2 commits into from
May 18, 2023
Merged

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented May 5, 2023

Description

Updates the ddf_vs_databinning test to use new DDF API.

(does not remove it from the skip list)

Type of change

  • Bug fix~~
  • New feature~~
  • Documentation update~~
  • Other~~

Fix for skip test :-)

How Has This Been Tested?

Ran on my mac, recommend we don't skip the entire file but only the exemplar failing test in the future.

Reminders:

  • Please follow the style guidelines of this project.
  • Please perform a self-review of your code before submitting a PR and asking others to review it.
  • Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

- [ ] I have commented my code where applicable.
- [ ] I have updated the release notes.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added debugging support to my changes.
- [ ] I have added tests that prove my fix is effective or that my feature works.
- [ ] I have confirmed new and existing unit tests pass locally with my changes.
~- [ ] I have added new baselines for any new tests to the repo.~~
- [ ] I have NOT made any changes to protocol or public interfaces in an RC branch.

@cyrush
Copy link
Member Author

cyrush commented May 5, 2023

Screen Shot 2023-05-05 at 1 47 33 PM

@cyrush
Copy link
Member Author

cyrush commented May 5, 2023

We should only skip:

  • ddf_vs_dbinning_with_coords
  • DBin with Coords
  • Orig Equals DBIN with Coords

Need to add missing baselines as well.

@cyrush cyrush requested a review from biagas May 15, 2023 18:16
@cyrush cyrush merged commit 9a90cbf into develop May 18, 2023
@cyrush cyrush deleted the task/2023_05_update_ddf_api_in_test branch May 18, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants