Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add "exposeFilename" option to plugin-vue #5535

Closed
wants to merge 1 commit into from
Closed

feat: add "exposeFilename" option to plugin-vue #5535

wants to merge 1 commit into from

Conversation

JohMun
Copy link

@JohMun JohMun commented Nov 3, 2021

Description

Allows "exposeFilename" option for vitejs/plugin-vue

Fixes #5071

  • New Feature
  • Documentation update

@JohMun JohMun changed the title Add option 'exposeFilename' to plugin-vue feat: add "exposeFilename" option to plugin-vue Nov 3, 2021
bluwy
bluwy reviewed Mar 20, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good feat for me given it's a feature vue-loader support. This needs a rebase though, and would be great to have tests for it too.

@bluwy bluwy requested a review from haoqunjiang March 20, 2022 16:24
@haoqunjiang
Copy link
Member

This functionality is covered by the __VUE_PROD_DEVTOOLS__ flag too, and it's fixed in #4984

IMHO, since the __file field is only meaningful for the devtool, we don't need yet another option for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy left review comments

@haoqunjiang haoqunjiang Awaiting requested review from haoqunjiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to receive the filename (__file) when importing a vue component in production builds
4 participants
@JohMun @haoqunjiang @bluwy @Shinigami92