Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: legacy no emit worker #9500

Merged
merged 8 commits into from
Aug 10, 2022
Merged

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Aug 2, 2022

Description

fix: #9305

Additional context

In the generateBundle hook,
we'll delete the assets from the legacy bundle to avoid emitting duplicate assets.
But that's still a waste of computing resource.
So we add this flag to avoid emitting the asset in the first place whenever possible.

worker as assets will delete by plugin-legacy. So make the worker emit asset like emit css, avoid delete worker asset in legacy building.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@poyoho poyoho added plugin: legacy p4-important Violate documented behavior or significantly improves performance (priority) feat: web workers labels Aug 2, 2022
@patak-dev patak-dev merged commit 9d0b18b into vitejs:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: web workers p4-important Violate documented behavior or significantly improves performance (priority) plugin: legacy
Projects
None yet
3 participants