wip - test slack notification

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
vitessio · Oct 15, 2024 · 40b0c85 · 40b0c85
1 parent 654e41d
commit 40b0c85
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 62 deletions.
diff --git a/.github/workflows/docker_build_images.yml b/.github/workflows/docker_build_images.yml
@@ -1,5 +1,6 @@
 name: Build Docker Images
 on:
+  pull_request:
   push:
     branches:
       - main
@@ -28,12 +29,11 @@ jobs:
       - name: Check out code
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
 
-      - name: Login to Docker Hub
-        if: needs.push.outputs.push == 'true'
-        uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0
-        with:
-          username: ${{ secrets.DOCKERHUB_USERNAME }}
-          password: ${{ secrets.DOCKERHUB_TOKEN }}
+#      - name: Login to Docker Hub
+#        uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0
+#        with:
+#          username: ${{ secrets.DOCKERHUB_USERNAME }}
+#          password: ${{ secrets.DOCKERHUB_TOKEN }}
 
       - name: Set Dockerfile path
         run: |
@@ -45,7 +45,7 @@ jobs:
         with:
           context: .
           file: ${{ env.DOCKERFILE }}
-          push: true
+          push: false
           tags: vitess/vttestserver:${{ matrix.branch }}
 
       ######
@@ -66,22 +66,9 @@ jobs:
         with:
           context: .
           file: ${{ env.DOCKERFILE }}
-          push: true
+          push: false
           tags: ${{ env.DOCKER_TAG }}
 
-      #####
-      # Slack notification if vttestserver build fails
-      #####
-      - name: Slack Workflow Notification
-        if: startsWith(github.ref, 'refs/tags/') == false && failure()
-        uses: Gamesight/slack-workflow-status@68bf00d0dbdbcb206c278399aa1ef6c14f74347a # v1.3.0
-        with:
-          repo_token: ${{secrets.GITHUB_TOKEN}}
-          slack_webhook_url: ${{secrets.SLACK_WEBHOOK_URL}}
-          channel: '#docker-build-notifications'
-          name: 'Docker Build Notification'
-
-
   build_and_push_lite:
     name: Build and push lite
     runs-on: ubuntu-latest
@@ -96,12 +83,11 @@ jobs:
       - name: Check out code
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
 
-      - name: Login to Docker Hub
-        if: needs.push.outputs.push == 'true'
-        uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0
-        with:
-          username: ${{ secrets.DOCKERHUB_USERNAME }}
-          password: ${{ secrets.DOCKERHUB_TOKEN }}
+#      - name: Login to Docker Hub
+#        uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0
+#        with:
+#          username: ${{ secrets.DOCKERHUB_USERNAME }}
+#          password: ${{ secrets.DOCKERHUB_TOKEN }}
 
       - name: Set Dockerfile path
         run: |
@@ -117,7 +103,7 @@ jobs:
         with:
           context: .
           file: ${{ env.DOCKERFILE }}
-          push: true
+          push: false
           tags: vitess/lite:${{ matrix.branch }}
 
       ######
@@ -142,21 +128,9 @@ jobs:
         with:
           context: .
           file: ${{ env.DOCKERFILE }}
-          push: true
+          push: false
           tags: ${{ env.DOCKER_TAG }}
 
-      #####
-      # Slack notification if lite build fails
-      #####
-      - name: Slack Workflow Notification
-        if: failure()
-        uses: Gamesight/slack-workflow-status@68bf00d0dbdbcb206c278399aa1ef6c14f74347a # v1.3.0
-        with:
-          repo_token: ${{secrets.GITHUB_TOKEN}}
-          slack_webhook_url: ${{secrets.SLACK_WEBHOOK_URL}}
-          channel: '#docker-build-notifications'
-          name: 'Docker Build Notification'
-
   build_and_push_components:
     name: Build and push
     runs-on: gh-hosted-runners-16cores-1
@@ -174,12 +148,11 @@ jobs:
       - name: Check out code
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
 
-      - name: Login to Docker Hub
-        if: needs.push.outputs.push == 'true'
-        uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0
-        with:
-          username: ${{ secrets.DOCKERHUB_USERNAME }}
-          password: ${{ secrets.DOCKERHUB_TOKEN }}
+#      - name: Login to Docker Hub
+#        uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0
+#        with:
+#          username: ${{ secrets.DOCKERHUB_USERNAME }}
+#          password: ${{ secrets.DOCKERHUB_TOKEN }}
 
       - name: Set Docker context path
         run: |
@@ -190,7 +163,7 @@ jobs:
         uses: docker/build-push-action@ca052bb54ab0790a636c9b5f226502c73d547a25 # v5.4.0
         with:
           context: ${{ env.DOCKER_CTX }}
-          push: true
+          push: false
           tags: vitess/${{ matrix.component }}:latest
           build-args: |
             VT_BASE_VER=latest
@@ -201,7 +174,7 @@ jobs:
         uses: docker/build-push-action@ca052bb54ab0790a636c9b5f226502c73d547a25 # v5.4.0
         with:
           context: ${{ env.DOCKER_CTX }}
-          push: true
+          push: false
           tags: vitess/${{ matrix.component }}:latest-${{ matrix.debian }}
           build-args: |
             VT_BASE_VER=latest
@@ -233,7 +206,7 @@ jobs:
         uses: docker/build-push-action@ca052bb54ab0790a636c9b5f226502c73d547a25 # v5.4.0
         with:
           context: ${{ env.DOCKER_CTX }}
-          push: true
+          push: false
           tags: ${{ env.DOCKER_TAG }}
           build-args: |
             VT_BASE_VER=${{ env.TAG_NAME }}
@@ -246,20 +219,26 @@ jobs:
         uses: docker/build-push-action@ca052bb54ab0790a636c9b5f226502c73d547a25 # v5.4.0
         with:
           context: ${{ env.DOCKER_CTX }}
-          push: true
+          push: false
           tags: ${{ env.DOCKER_TAG_DEFAULT_DEBIAN }}
           build-args: |
             VT_BASE_VER=${{ env.TAG_NAME }}
             DEBIAN_VER=${{ matrix.debian }}-slim
 
-      #####
-      # Slack notification if component build fails
-      #####
-      - name: Slack Workflow Notification
-        if: failure()
-        uses: Gamesight/slack-workflow-status@68bf00d0dbdbcb206c278399aa1ef6c14f74347a # v1.3.0
-        with:
-          repo_token: ${{secrets.GITHUB_TOKEN}}
-          slack_webhook_url: ${{secrets.SLACK_WEBHOOK_URL}}
-          channel: '#docker-build-notifications'
-          name: 'Docker Build Notification'
+  slack_notification:
+    name: Slack Notification if failed
+    runs-on: ubuntu-latest
+    needs:
+      - build_and_push_vttestserver
+      - build_and_push_lite
+      - build_and_push_components
+    if: ${{ needs.build_and_push_vttestserver.result == 'failure' || needs.build_and_push_lite.result == 'failure' || needs.build_and_push_components.result == 'failure' }}
+    steps:
+    - name: Slack Workflow Notification
+      uses: Gamesight/slack-workflow-status@68bf00d0dbdbcb206c278399aa1ef6c14f74347a # v1.3.0
+      with:
+        repo_token: ${{secrets.GITHUB_TOKEN}}
+        slack_webhook_url: ${{secrets.SLACK_WEBHOOK_URL}}
+        channel: '#docker-build-notifications'
+        name: 'Docker Build Notification'
+        icon_url: https://avatars.githubusercontent.com/u/33043890?s=96&v=4
diff --git a/docker/binaries/vtbackup/Dockerfile b/docker/binaries/vtbackup/Dockerfile
@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+TEST WIP, this will fail the build
+
 ARG VT_BASE_VER=latest
 ARG DEBIAN_VER=stable-slim
 

diff --git a/docker/lite/Dockerfile b/docker/lite/Dockerfile
@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+TEST WIP, this will fail the build
+
 FROM --platform=linux/amd64 golang:1.23.2-bullseye AS builder
 
 # Allows docker builds to set the BUILD_NUMBER

diff --git a/docker/vttestserver/Dockerfile.mysql80 b/docker/vttestserver/Dockerfile.mysql80
@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+TEST WIP, this will fail the build
+
 FROM --platform=linux/amd64 golang:1.23.2-bullseye AS builder
 
 # Allows docker builds to set the BUILD_NUMBER