Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Release container images into Github Packages repository #128

Merged
merged 7 commits into from
Jan 11, 2022

Conversation

migmartri
Copy link
Contributor

@migmartri migmartri commented Jan 11, 2022

Update goreleaser to also build container images with latest versions of the binary inside pushed to Github packages repository ghcr.io/vmware-tanzu/asset-relocation-tool-for-kubernetes

The Dockerfile has also been updated to leverage the binary created by goreleaser itself

Tested it and an image was built and pushed as expected https://github.com/vmware-tanzu/asset-relocation-tool-for-kubernetes/pkgs/container/asset-relocation-tool-for-kubernetes/13030106?tag=v0.3.61-pre https://github.com/vmware-tanzu/asset-relocation-tool-for-kubernetes/actions/runs/1683473654

Refs #127

@vmwclabot
Copy link

@migmartri, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Copy link
Contributor

@petewall petewall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dockerfile: Dockerfile
image_templates:
- "ghcr.io/vmware-tanzu/asset-relocation-tool-for-kubernetes:{{ .Tag }}"
- "ghcr.io/vmware-tanzu/asset-relocation-tool-for-kubernetes:latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean the image is living here and not on projects.registry.vmware.com/tanzu_isv_engineering/relok8s? We should update the pipeline.yaml to find the image in the right location, then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, sorry, I missed linking the task #127

This whole task started because I noticed that we are no longer building the external container images since we've moved the release process outside.

Miguel Martinez Trivino added 6 commits January 11, 2022 16:35
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
@migmartri migmartri merged commit 5754153 into main Jan 11, 2022
@migmartri migmartri deleted the 127-build-image-on-release branch January 11, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants