-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Release container images into Github Packages repository #128
Conversation
@migmartri, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
4e7e412
to
3bcf307
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dockerfile: Dockerfile | ||
image_templates: | ||
- "ghcr.io/vmware-tanzu/asset-relocation-tool-for-kubernetes:{{ .Tag }}" | ||
- "ghcr.io/vmware-tanzu/asset-relocation-tool-for-kubernetes:latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean the image is living here and not on projects.registry.vmware.com/tanzu_isv_engineering/relok8s
? We should update the pipeline.yaml to find the image in the right location, then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, sorry, I missed linking the task #127
This whole task started because I noticed that we are no longer building the external container images since we've moved the release process outside.
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Update goreleaser to also build container images with latest versions of the binary inside pushed to Github packages repository
ghcr.io/vmware-tanzu/asset-relocation-tool-for-kubernetes
The Dockerfile has also been updated to leverage the binary created by goreleaser itself
Tested it and an image was built and pushed as expected https://github.com/vmware-tanzu/asset-relocation-tool-for-kubernetes/pkgs/container/asset-relocation-tool-for-kubernetes/13030106?tag=v0.3.61-pre https://github.com/vmware-tanzu/asset-relocation-tool-for-kubernetes/actions/runs/1683473654
Refs #127