Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove dependency references #148

Merged
merged 5 commits into from
Feb 17, 2022

Conversation

migmartri
Copy link
Contributor

@migmartri migmartri commented Feb 16, 2022

Removes the dependencies references from Chart.yaml as well as the lock file recursively for all chart and subcharts. See the attached task for more context on the change.

Closes #142

@vmwclabot
Copy link

@migmartri, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

func saveChart(chart *chart.Chart, toChartFilename string) error {
cwd, _ := os.Getwd()
tempDir, err := ioutil.TempDir(cwd, "relok8s-*")
tempDir, err := ioutil.TempDir("", "relok8s-package*")
Copy link
Contributor Author

@migmartri migmartri Feb 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a way to ensure that no temporary directories are left in CWD. This change is orthogonal to the context of this task to be fair.

@vmwclabot
Copy link

@migmartri, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Miguel Martinez Trivino added 3 commits February 16, 2022 16:05
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Copy link
Member

@tompizmor tompizmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
@migmartri migmartri merged commit 50f7d01 into vmware-tanzu:main Feb 17, 2022
@migmartri migmartri deleted the 142-remove-deps-refs branch February 17, 2022 21:33
petewall pushed a commit that referenced this pull request Apr 19, 2022
* feat: Remove dependency references

Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly vendor and fix subcharts
3 participants