-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove dependency references #148
Conversation
@migmartri, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
pkg/mover/chart.go
Outdated
func saveChart(chart *chart.Chart, toChartFilename string) error { | ||
cwd, _ := os.Getwd() | ||
tempDir, err := ioutil.TempDir(cwd, "relok8s-*") | ||
tempDir, err := ioutil.TempDir("", "relok8s-package*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a way to ensure that no temporary directories are left in CWD. This change is orthogonal to the context of this task to be fair.
@migmartri, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
f592ffe
to
4db9b36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
* feat: Remove dependency references Signed-off-by: Miguel Martinez Trivino <mtrivino@vmware.com>
Removes the dependencies references from Chart.yaml as well as the lock file recursively for all chart and subcharts. See the attached task for more context on the change.
Closes #142