Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh volumes logic #498

Merged
merged 2 commits into from
Oct 31, 2019
Merged

refresh volumes logic #498

merged 2 commits into from
Oct 31, 2019

Conversation

lminzhw
Copy link
Contributor

@lminzhw lminzhw commented Oct 30, 2019

After this PR merged, the volume behavior would change to this.


Before all, we have a job like this:

metadata:
  generateName: lm-volume-
  name: lm-volume-drhwm
spec:
  volumes:
  - mountPath: /mnt11
  - mountPath: /mnt21
    volumeClaimName: lm-pvc
  - mountPath: /mnt31
    volumeClaim:
      accessModes:
        - ReadWriteOnce
      resources:
        requests:
          storage: 1Gi
  • The first volume would be an emptyDir for all container at /mnt11.
  • The second volume would mount lm-pvc to /mnt21.
  • The third volume would create a pvc following volumeClaim with name format {jobname}-volume-{randomStr} and mount it to /mnt31.

So the info recorded in controlledResources would be like this

status:
  controlledResources:
    volume-emptyDir-lm-volume-drhwm-volume-7hmf0d7qfonv: lm-volume-drhwm-volume-7hmf0d7qfonv
    volume-pvc-lm-pvc: lm-pvc
    volume-pvc-lm-volume-drhwm-volume-4t5agfb78vfj: lm-volume-drhwm-volume-4t5agfb78vfj

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @lminzhw,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 9ebd26a0-fae2-11e9-968d-e17190c27649

@TravisBuddy
Copy link

Hey @lminzhw,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: cdeed130-faf6-11e9-968d-e17190c27649

@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2019
@TravisBuddy
Copy link

Hey @lminzhw,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 6e3077c0-fb01-11e9-968d-e17190c27649

@k82cn
Copy link
Member

k82cn commented Oct 31, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, lminzhw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@volcano-sh-bot volcano-sh-bot merged commit e5fd206 into volcano-sh:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants