Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use future idle resources when checking if task can fit node #585

Merged
merged 1 commit into from
Dec 6, 2019
Merged

use future idle resources when checking if task can fit node #585

merged 1 commit into from
Dec 6, 2019

Conversation

mateuszlitwin
Copy link
Contributor

@mateuszlitwin mateuszlitwin commented Dec 5, 2019 •
edited
Loading

Future idle resources (current idle resources + resources being released) are considered for pipelining during allocate and preempt action.

Fixes a bug when task was used as preemptor on the first iteration of the preempt loop despite task's job being "pipelined".
Fixes issue #582

@volcano-sh-bot volcano-sh-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 5, 2019
@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Dec 5, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @mateuszlitwin,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 48b24100-16fd-11ea-93d3-257117e2c129

@TravisBuddy
Copy link

Hey @mateuszlitwin,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: dfb54860-1700-11ea-93d3-257117e2c129

@mateuszlitwin
use future idle resources when checking if task can fit node
b167ec8 
Future idle resources (current idle resources + resources being released) are considered for pipelining during allocate and preempt action.

Fixes read-write race condition in FakeEvictor
Fixes a bug when task was used as preemptor on the first iteration of the preempt loop despite task's job being "pipelined".
Fixes issue #582
@TravisBuddy
Copy link

Hey @mateuszlitwin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 6bd40d40-17b5-11ea-b5b2-a33d2660b61c

@k82cn
Copy link
Member

k82cn commented Dec 6, 2019

/lgtm
/approve

LGTM overall :)

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, mateuszlitwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2019
@volcano-sh-bot volcano-sh-bot merged commit 0f1bb49 into volcano-sh:master Dec 6, 2019
@mateuszlitwin mateuszlitwin deleted the mlitwin-correct-pipelining branch December 6, 2019 18:03
@k82cn k82cn mentioned this pull request Dec 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 Awaiting requested review from hex108

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mateuszlitwin @TravisBuddy @k82cn @volcano-sh-bot