Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vivo as adopter #592

Merged
merged 1 commit into from
Dec 7, 2019
Merged

Add Vivo as adopter #592

merged 1 commit into from
Dec 7, 2019

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Dec 7, 2019

Add Vivo as adopter

@k82cn
Add Vivo as adopter
fa9ea66 
Add Vivo as adopter
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2019
@k82cn
Copy link
Member Author

k82cn commented Dec 7, 2019

/cc @zionwu

@volcano-sh-bot
Copy link
Contributor

@k82cn: GitHub didn't allow me to request PR reviews from the following users: zionwu.

Note that only volcano-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @zionwu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2019
@TravisBuddy
Copy link

Hey @k82cn,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: dfb06ba0-189b-11ea-95f4-abb8efddad88

@k82cn k82cn added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2019
@k82cn
Copy link
Member Author

k82cn commented Dec 7, 2019

xref #308 (comment)

@k82cn k82cn merged commit f975dd4 into volcano-sh:master Dec 7, 2019
@k82cn k82cn deleted the add_vivo branch December 7, 2019 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k82cn @volcano-sh-bot @TravisBuddy