Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change storage of ssh pem from configmap to secret for ssh plugin #603

Merged
merged 1 commit into from
Dec 14, 2019
Merged

change storage of ssh pem from configmap to secret for ssh plugin #603

merged 1 commit into from
Dec 14, 2019

Conversation

sivanzcw
Copy link
Contributor

#549

  • change pem backend storage from comfigmap to secret

  • secret name is jobname-jobid-ssh

mxnet-job-v2-e7f18111-1cec-11ea-b688-fa163ec79500-ssh
  • Remained configmap of job using ssh plugin will be deleted by gc if job is deleted

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 12, 2019
hzxuzhonghu
hzxuzhonghu reviewed Dec 13, 2019
View reviewed changes
pkg/apis/helpers/helpers.go Outdated
@@ -145,6 +163,16 @@ func DeleteConfigmap(job *vcbatch.Job, kubeClients kubernetes.Interface, cmName
return nil
}

// DeleteSecret delete secret
func DeleteSecret(job *vcbatch.Job, kubeClients kubernetes.Interface, secretName string) error {
err := kubeClients.CoreV1().ConfigMaps(job.Namespace).Delete(secretName, nil)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why configmaps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error coding, modified it, thanks

@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2019
@TravisBuddy
Copy link

Hey @sivanzcw,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 48563c00-1d58-11ea-a2fb-51cb67500490

@k82cn
Copy link
Member

k82cn commented Dec 13, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, sivanzcw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2019
@k82cn
Copy link
Member

k82cn commented Dec 13, 2019

LGTM overall, please help to fix CI error :)

@TravisBuddy
Copy link

Hey @sivanzcw,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 3ae61890-1d87-11ea-a2fb-51cb67500490

@TravisBuddy
Copy link

Hey @sivanzcw,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: a7df2130-1d87-11ea-a2fb-51cb67500490

@k82cn
Copy link
Member

k82cn commented Dec 14, 2019

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2019
@volcano-sh-bot volcano-sh-bot merged commit ad9ea1e into volcano-sh:master Dec 14, 2019
@k82cn k82cn mentioned this pull request Dec 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu left review comments

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sivanzcw @TravisBuddy @k82cn @volcano-sh-bot @hzxuzhonghu