Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webhook path. #606

Merged
merged 1 commit into from
Dec 14, 2019
Merged

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Dec 14, 2019

Signed-off-by: Klaus Ma klaus1982.cn@gmail.com

Signed-off-by: Klaus Ma <klaus1982.cn@gmail.com>
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2019
@TravisBuddy
Copy link

Hey @k82cn,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 416cb3e0-1e63-11ea-a424-4f8e788bb22e

@k82cn k82cn added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2019
@volcano-sh-bot volcano-sh-bot merged commit 9d66a9a into volcano-sh:master Dec 14, 2019
@hzxuzhonghu
Copy link
Collaborator

Generally, this is a bad idea with backward compatibility issue.

@k82cn k82cn deleted the update_wh_path branch December 25, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants