Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor webhook org. #644

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Refactor webhook org. #644

merged 1 commit into from
Dec 26, 2019

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Dec 25, 2019

Signed-off-by: Klaus Ma klaus1982.cn@gmail.com

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 25, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d0ed8d40-271f-11ea-9fe8-03452f69915b

@TravisBuddy
Copy link

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 180a8200-2720-11ea-9fe8-03452f69915b

@TravisBuddy
Copy link

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 5022dc00-2720-11ea-9fe8-03452f69915b

@k82cn
Refactor webhook org.
e34e62f 
Signed-off-by: Klaus Ma <klaus1982.cn@gmail.com>
@TravisBuddy
Copy link

Hey @k82cn,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 01a2b9a0-272b-11ea-9fe8-03452f69915b

@k82cn k82cn added the lgtm Indicates that a PR is ready to be merged. label Dec 26, 2019
@volcano-sh-bot volcano-sh-bot merged commit 3d74da7 into volcano-sh:master Dec 26, 2019
@k82cn k82cn deleted the webhook_refactor branch January 20, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k82cn @volcano-sh-bot @TravisBuddy