Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resource predicate. #732

Closed
wants to merge 1 commit into from
Closed

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Mar 8, 2020

Signed-off-by: Klaus Ma klaus1982.cn@gmail.com

Signed-off-by: Klaus Ma <klaus1982.cn@gmail.com>
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 8, 2020
@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: cfa4f200-6146-11ea-b333-4fa8171c3056

@k82cn
Copy link
Member Author

k82cn commented Mar 9, 2020

We can not do that because of preemption & reclaim :)

/cc @jiangkaihua

@k82cn k82cn closed this Mar 9, 2020
@volcano-sh-bot
Copy link
Contributor

@k82cn: GitHub didn't allow me to request PR reviews from the following users: jiangkaihua.

Note that only volcano-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

We can not do that because of preemption & reclaim :)

/cc @jiangkaihua

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k82cn k82cn deleted the add_res_pred branch March 9, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants