Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug: capability validation failed when some running jobs finished or deleted #959

Merged
merged 2 commits into from
Jul 29, 2020
Merged

fix bug: capability validation failed when some running jobs finished or deleted #959

merged 2 commits into from
Jul 29, 2020

Conversation

Thor-wl
Copy link
Contributor

@Thor-wl Thor-wl commented Jul 28, 2020

fix point:
considering the request resource of inqueue job as part of allocated resource
Signed-off-by: Thor 1187526662@qq.com

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 28, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @Thor-wl,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 9903acb0-d099-11ea-b8d2-e37d5f97d09d

hzxuzhonghu
hzxuzhonghu reviewed Jul 28, 2020
View reviewed changes
pkg/scheduler/plugins/proportion/proportion.go Outdated
@@ -18,6 +18,7 @@ package proportion

import (
"k8s.io/klog"
"volcano.sh/volcano/pkg/scheduler/actions/enqueue"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

donot make actions and plugins import each other

@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @Thor-wl,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: abbf2100-d0b1-11ea-b8d2-e37d5f97d09d

@Thor-wl
fix bug of queue capability lose efficacy
b11ac07 
Signed-off-by: Thor <1187526662@qq.com>
@TravisBuddy
Copy link

Travis tests have failed

Hey @Thor-wl,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: fb293060-d0b5-11ea-b8d2-e37d5f97d09d

@TravisBuddy
Copy link

Travis tests have failed

Hey @Thor-wl,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: a90713a0-d0b6-11ea-b8d2-e37d5f97d09d

@hzxuzhonghu hzxuzhonghu added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2020
@Thor-wl
remove redudant argument
bddfe01 
Signed-off-by: Thor <1187526662@qq.com>
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @Thor-wl,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: aeb12f80-d0bf-11ea-b8d2-e37d5f97d09d

hzxuzhonghu
hzxuzhonghu approved these changes Jul 29, 2020
View reviewed changes
Copy link
Collaborator

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I will optimize it in the following pr

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: hzxuzhonghu, Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit f0bd7db into volcano-sh:master Jul 29, 2020
This was referenced Jul 29, 2020
Merged
Merged
volcano-sh-bot added a commit that referenced this pull request Jul 30, 2020
@volcano-sh-bot
Merge pull request #971 from hzxuzhonghu/automated-cherry-pick-of-#959-…
c5f6bc8 
…#966-xu-release-1.0

Automated cherry pick of #959: fix bug of queue capability lose efficacy #966: Record Inqueue job resource request in queueAttr
This was referenced Jul 30, 2020
Closed
Merged
volcano-sh-bot added a commit that referenced this pull request Jul 31, 2020
@volcano-sh-bot
Merge pull request #974 from hzxuzhonghu/automated-cherry-pick-of-#959-…
4c797d7 
…#966-xu-release-0.4

Automated cherry pick of #959: fix bug of queue capability lose efficacy #966: Record Inqueue job resource request in queueAttr
@hzxuzhonghu hzxuzhonghu mentioned this pull request Sep 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@hzxuzhonghu hzxuzhonghu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thor-wl @TravisBuddy @volcano-sh-bot @hzxuzhonghu