Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from OpenSSL #1164

Closed
wants to merge 2 commits into from
Closed

Migrate away from OpenSSL #1164

wants to merge 2 commits into from

Conversation

jensmeindertsma
Copy link

This pull request swaps out attohttpc for reqwest with rustls and removes soooo much stuff regarding OpenSSL as we don't need it anymore. This is also going to be crucial for ARM64 and MUSL support, as we now don't need to build through Docker anymore.

@charlespierce I know you were thinking about this, what are your thoughts on this PR? Can you leave a review? I think this change makes a lot of sense, especially with the enormous struggles OpenSSL + Rust have presented us with.

#1161 and #1163 need the changes from this PR

This was referenced Feb 22, 2022
@jensmeindertsma
Copy link
Author

This PR does break the download URL's though, as we no longer parse the OpenSSL version and also no longer build for a specific OpenSSL version, the download url is now simply suffixed with -linux. I don't think this is a major issue

@charlespierce
Copy link
Contributor

Hi @jensmeindertsma, we actually intentionally migrated off of reqwest, because the async executor bloated both the build time and the compiled binary: See #733 for a more thorough description.

attohttpc has a rustls feature as well, so should we make the switch to use Rustls, we would likely go that route rather than switching back to reqwest with all of its extra, unused, features. We have an RFC about that switch open right now, so it's by no means a guarantee, but would be happy to have your thoughts: volta-cli/rfcs#47

Your point about the install script is a good one, I'll make sure to add that to the RFC as well, since we'll need a good plan for that going forward.

@jensmeindertsma
Copy link
Author

@charlespierce Ah okay, I'd be happy to use attohttpc instead! Let's chat in the RFC and then I can put together a new PR once we've worked out some details.

@jensmeindertsma jensmeindertsma deleted the use-rustls branch February 22, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants