This repository has been archived by the owner on Sep 27, 2021. It is now read-only.
[WIP] Electrostatics joshs development #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on between different types
JensWehner
reviewed
Jun 6, 2019
include/votca/csg/atomcgconverter.h
Outdated
| #ifndef VOTCA_CSG_ATOMTOCGCONVERTER_H | ||
| #define VOTCA_CSG_ATOMTOCGCONVERTER_H | ||
|
|
||
| #include <list> |
…gmxtopology reader, switched pointer to reference
|
Still need tests for topolgy type container, dlpoly file readers and writers. |
|
ping @JoshuaSBrown |
|
This pull request was kept open for all the review comments which are addressed in #381 I believe they have been addressed now closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combination of the electrostatics branch and joshs-development branch.