This repository has been archived by the owner on Sep 27, 2021. It is now read-only.
Piece wize boundaries #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JensWehner
reviewed
Nov 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
=======================================
+ Coverage 60.9% 61% +<.1%
=======================================
Files 129 129
Lines 6290 6298 +8
=======================================
+ Hits 3835 3845 +10
+ Misses 2455 2453 -2
Continue to review full report at Codecov.
|
|
Misses code formatting. |
|
@JensWehner Can you review/approve? |
junghans
approved these changes
Dec 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is a piece wise merge of my development branch #381, I'm going to break it up into a bunch of small merges because it is too much to do all at once. Here, the boundary class is updated.
Methods are made const
pragma once is included
header guards are updated
A clone method is introduced which allows safe copying of the class, which is needed because the boundarycondition class is stored as a dynamic pointer.