-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
…leId in lammpsdatareader.cc
…into piece-wize-basebead
include/votca/csg/basebead.h
Outdated
molecule_item_(nullptr), | ||
mass_(0.0), | ||
bead_position_set_(false){}; | ||
BaseBead() : topology_item_(nullptr), mass_(0.0), bead_position_set_(false){}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can initialize them below in th elist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would set the values of these things not in the constructor but when they are declared in the private section of the class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change please
|
Requires that votca/votca#235 is merged. |
This one needs to be merged next, @JensWehner please review! |
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
=======================================
+ Coverage 61% 61% +<.1%
=======================================
Files 129 128 -1
Lines 6298 6299 +1
=======================================
+ Hits 3845 3846 +1
Misses 2453 2453
Continue to review full report at Codecov.
|
include/votca/csg/basebead.h
Outdated
molecule_item_(nullptr), | ||
mass_(0.0), | ||
bead_position_set_(false){}; | ||
BaseBead() : topology_item_(nullptr), mass_(0.0), bead_position_set_(false){}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change please
…to piece-wize-basebead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please move the defualt values from the constructor to the private declaration
@JensWehner they have been, which ones are you referring too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoshuaSBrown I am sorry, I was confused. Good work.
Updating base bead from issue https://github.com/votca/csg/pull/381/files: