Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure debian 8 systems for acceptance tests #411

Merged
merged 1 commit into from
Oct 24, 2017

Conversation

btravouillon
Copy link
Member

@@ -35,6 +35,11 @@

hosts.each do |host|
on host, puppet('module', 'install', 'puppetlabs-stdlib'), acceptable_exit_codes: [0, 1]

if fact('osfamily') == 'Debian' && fact('operatingsystemmajrelease') == '8'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a comment above, like "work around issue with openhpid not existing".

Also, switch to structured facts, so fact('os.family'), I believe, and fact('os.release.major')?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, this is still Puppet 3 compatible, so I guess leave unstructured for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment:
# For Debian 8 "jessie", we need
# - pacemaker and crmsh delivered in jessie-backports only
# - openhpid post-install may fail (https://bugs.debian.org/785287)

@@ -35,6 +35,11 @@

hosts.each do |host|
on host, puppet('module', 'install', 'puppetlabs-stdlib'), acceptable_exit_codes: [0, 1]

if fact('osfamily') == 'Debian' && fact('operatingsystemmajrelease') == '8'
on host, 'echo deb http://ftp.debian.org/debian jessie-backports main >> /etc/apt/sources.list'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove the one in the docker nodesets. Also, we need to do this for Debian 7 as well, maybe we can use the codename fact so we don't have to have two different conditionals?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debian 7 is not in the support matrix. I will update the debian-8 nodeset to reflect the change in modulesync_config.

Copy link
Contributor

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than the issues mentioned in comments

* pacemaker and crmsh are delivered in jessie-backports
* openhpid post-install may fail (voxpupuli#408)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants