-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure debian 8 systems for acceptance tests #411
Conversation
btravouillon
commented
Oct 23, 2017
- pacemaker and crmsh are delivered in jessie-backports
- openhpid post-install may fail (openhpid dependency issue #408)
cf62dc9
to
4114e7e
Compare
spec/spec_helper_acceptance.rb
Outdated
@@ -35,6 +35,11 @@ | |||
|
|||
hosts.each do |host| | |||
on host, puppet('module', 'install', 'puppetlabs-stdlib'), acceptable_exit_codes: [0, 1] | |||
|
|||
if fact('osfamily') == 'Debian' && fact('operatingsystemmajrelease') == '8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should be a comment above, like "work around issue with openhpid not existing".
Also, switch to structured facts, so fact('os.family')
, I believe, and fact('os.release.major')
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, this is still Puppet 3 compatible, so I guess leave unstructured for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment:
# For Debian 8 "jessie", we need
# - pacemaker and crmsh delivered in jessie-backports only
# - openhpid post-install may fail (https://bugs.debian.org/785287)
spec/spec_helper_acceptance.rb
Outdated
@@ -35,6 +35,11 @@ | |||
|
|||
hosts.each do |host| | |||
on host, puppet('module', 'install', 'puppetlabs-stdlib'), acceptable_exit_codes: [0, 1] | |||
|
|||
if fact('osfamily') == 'Debian' && fact('operatingsystemmajrelease') == '8' | |||
on host, 'echo deb http://ftp.debian.org/debian jessie-backports main >> /etc/apt/sources.list' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove the one in the docker nodesets. Also, we need to do this for Debian 7 as well, maybe we can use the codename fact so we don't have to have two different conditionals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, pull in these changes https://github.com/voxpupuli/modulesync_config/pull/403/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debian 7 is not in the support matrix. I will update the debian-8 nodeset to reflect the change in modulesync_config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, other than the issues mentioned in comments
4114e7e
to
0181ecb
Compare
* pacemaker and crmsh are delivered in jessie-backports * openhpid post-install may fail (voxpupuli#408)
0181ecb
to
65b71f3
Compare