Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Debian 9 (#404) #416

Merged
merged 1 commit into from
Nov 4, 2017
Merged

support Debian 9 (#404) #416

merged 1 commit into from
Nov 4, 2017

Conversation

wyardley
Copy link
Contributor

This adds support to Debian 9
As currently implemented, it drops Debian 8 acceptance tests, though we could leave it as 8, or run both.

@wyardley
Copy link
Contributor Author

Seems to be some issues with bootstrapping on the Debian 9 Docker nodeset.

@wyardley
Copy link
Contributor Author

@juniorsysadmin I don't think we can implement / test this unless there's a way to make the Debian 9 acceptance tests work.

@wyardley
Copy link
Contributor Author

It works for me locally with CHECK=beaker instead of CHECK=acceptance, but still doesn't seem to in Travis

@btravouillon
Copy link
Member

For debian-9 support, we need beaker >= 3.9.0 (voxpupuli/beaker@23c7360)

Otherwise, beaker is not able to build the URL to download puppet:

debian-9-x64 23:31:02$ wget -O /tmp/puppet.deb http://apt.puppetlabs.com/puppetlabs-release-pc1-.deb

While the package name is puppetlabs-release-pc1-stretch.deb.

@btravouillon
Copy link
Member

With the workaround in .sync.yml (BEAKER_VERSION='~> 3.27'), the test fails on #404.
I was working on a patch earlier, I made it available at https://gist.github.com/actatux/9ef9ab961623b18526adebb05a9d2621

@wyardley wyardley added the enhancement New feature or request label Oct 27, 2017
@ekohl
Copy link
Member

ekohl commented Oct 27, 2017

$package_install_options = ['-t', 'jessie-backports']
needs to be just for Jessie. I assume Stretch won't need backports.

@wyardley
Copy link
Contributor Author

wyardley commented Nov 3, 2017

@ekohl:

needs to be just for Jessie. I assume Stretch won't need backports.
So like this, right" if versioncmp($::operatingsystemrelease, '8') == 0?

@wyardley
Copy link
Contributor Author

wyardley commented Nov 3, 2017

@actatux I updated the bit in params that @ekohl mentioned.

@ekohl ekohl removed the tests-fail label Nov 4, 2017
@ekohl
Copy link
Member

ekohl commented Nov 4, 2017

There might be a few differences when we modulesync but we can deal with that there.

@ekohl ekohl merged commit 0bbfe48 into voxpupuli:master Nov 4, 2017
@wyardley wyardley mentioned this pull request Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants