Fix variable type to allow authkey to be a string #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cedef, thanks for the PR. Can you check the used email adrress in the commit? It isn't associated with your github account. |
|
Email address added to my GH account :) Thank you ! |
alexjfisher
changed the title
alexjfisher
requested changes
Nov 20, 2017
spec/classes/corosync_spec.rb
Outdated
| authkey: 'mysecretkey' | ||
| ) | ||
| end | ||
| it 'should deploy authkey file' do |
There was a problem hiding this comment.
Can you fix the rubocop test failures by changing this to it 'deploys authkey file' do ?
There was a problem hiding this comment.
My mistake ! It's now fixed.
btravouillon
approved these changes
Nov 21, 2017
|
@cedef can you take a look at the failing rubocop run? |
|
Oh it is green now, but the email adress is again missing in your profile. Can you have a look? |
|
Done !
|
alexjfisher
approved these changes
Nov 21, 2017
|
Thanks @cedef ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to PR #69 which introduced the capability of corosync class to take
authkeyas a string ifauthkey_sourceis set to 'string'.Problem appeared at commit 42e13c7 when switching to Puppet 4 data types:
$authkeywas assigned a Stdlib::AbsolutePath data type.