Add SLES 12/15 Support #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thus far, there is no SLES added to the acceptance tests, which might be of interest. |
bastelfreak
reviewed
Mar 19, 2019
bastelfreak
reviewed
Mar 19, 2019
bastelfreak
reviewed
Mar 19, 2019
bastelfreak
reviewed
Mar 19, 2019
bastelfreak
reviewed
Mar 19, 2019
towo
force-pushed
the
feature/sles-support
branch
from
bc539f0
to
0db450b
Compare
bastelfreak
reviewed
Mar 27, 2019
spec/classes/corosync_spec.rb
Outdated
| context 'on SLES platforms' do | ||
| let :facts do | ||
| { | ||
| osfamily: 'Suse', |
There was a problem hiding this comment.
you also need to mock the os hash here. I'm not sure if it's easier or harder to migrate the whole file to rspec-puppet-facts 🤔
|
Dear @towo, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
This needs a rebase now. |
towo
force-pushed
the
feature/sles-support
branch
from
0db450b
to
682c896
Compare
towo
force-pushed
the
feature/sles-support
branch
from
7acfd86
to
cdf8f38
Compare
Going by corosync/pacemaker versions in SLES 12 and 15, I've added sane-ish defaults. Bonus points for checking for existence of SLE-HA repositories; checking if we have a registered HA product should be an optional feature.
towo
force-pushed
the
feature/sles-support
branch
from
cdf8f38
to
961637f
Compare
bastelfreak
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adds support for SUSE Linux Enterprise Server to the puppetlabs-corosync module.
No special care is given to ensure only supported clusters are used, that's for either a profile or a separate module.
This Pull Request (PR) fixes the following issues
n/a