Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Puppet 5 support; require Puppet 6.1.0 #501

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak
Copy link
Member Author

puppet 7 support will be added in another PR

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also clean up this:

# Binary() behaves different in Puppet 5 and 6
let(:expected_content) { facts[:puppetversion].to_i >= 6 ? "mysecretkey\n" : 'bXlzZWNyZXRrZXkK' }

spec/classes/corosync_spec.rb Outdated Show resolved Hide resolved
spec/classes/corosync_spec.rb Outdated Show resolved Hide resolved
@bastelfreak bastelfreak merged commit ee5ea0a into voxpupuli:master Mar 2, 2021
@bastelfreak bastelfreak deleted the puppet5 branch March 2, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants