Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MongoDB installation on RedHat family #606

Merged
merged 65 commits into from
Aug 20, 2021
Merged

Fix MongoDB installation on RedHat family #606

merged 65 commits into from
Aug 20, 2021

Conversation

hdep
Copy link
Contributor

@hdep hdep commented Feb 12, 2021

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@hdep hdep changed the title Fix centos WIP - Fix centos Feb 18, 2021
@alexjfisher alexjfisher mentioned this pull request Feb 22, 2021
Closed
@hdep
Copy link
Contributor Author

hdep commented Mar 1, 2021

Currently blocked :
Error: Execution of '/usr/bin/yum -d 0 -e 0 -y install mongodb-org-server' returned 1: Error: Nothing to do

So seems that the mongodb repository doesn't get installed

@hdep
Copy link
Contributor Author

hdep commented Mar 2, 2021

Current status :

  • mongodb get installed 3.6 by default
  • mongodb doesn't start New main PID 1145 does not belong to service, and PID file is not owned by root. Refusing.

@hdep
Copy link
Contributor Author

hdep commented Mar 3, 2021

Currently stuck, because i'm not able to find a proper systemd init wscript for mongos daemon. Any help appreciated.

@kenyon
Copy link
Member

kenyon commented Mar 5, 2021

Currently stuck, because i'm not able to find a proper systemd init wscript for mongos daemon. Any help appreciated.

@hdep I see something here, but also: https://jira.mongodb.org/browse/SERVER-3748

@hdep
Copy link
Contributor Author

hdep commented Aug 17, 2021

I just merged the PR.
Should I do something special to run acceptance tests on this PR ?

@ZloeSabo
Copy link
Contributor

ZloeSabo commented Aug 17, 2021 •
edited
Loading

Now bigger part of the pipeline is green, but there are still a couple of issues:

camptocamp/systemd:

  1. does not support puppet5, so that's why CI / Puppet 5 (Ruby 2.4) is failing. Seems that puppet5 does not support the deferred functions that module requires.
  2. it's actually deprecated and suggests using puppet/systemd instead.

Ubuntu: I just didn't check on 16.04. It's in EOL already, so I'd suggest removing it from the pipeline and add 20.04 instead. But if a maintainer in charge of this repo suggests fixing 16.04, we can take a look.

root-expert
root-expert requested changes Aug 17, 2021
View reviewed changes
Copy link
Member

@root-expert root-expert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puppet 5 failures can be ignored.

Support for Ubuntu 16.04 can be dropped since it's EoL. Let's add Ubuntu 20.04 and see if it passes.

.fixtures.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.sync.yml Outdated Show resolved Hide resolved
manifests/mongos.pp Outdated Show resolved Hide resolved
manifests/mongos/params.pp Show resolved Hide resolved
metadata.json Outdated Show resolved Hide resolved
hdep and others added 5 commits August 18, 2021 09:42
@hdep @root-expert
Update .fixtures.yml
c8f689d 
Co-authored-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
@hdep @root-expert
Update .github/workflows/ci.yml
b3ac32d 
Co-authored-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
@hdep @root-expert
Update .sync.yml
bbae78e 
Co-authored-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
@hdep @root-expert
Update metadata.json
b604248 
Co-authored-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
@hdep @root-expert
Update manifests/mongos.pp
c20928f 
Co-authored-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
@root-expert
Copy link
Member

Can you also pick the changes from PRs #616 and #617?

@root-expert @hdep
Drop Ubuntu 16/Add Ubuntu 20 support
9e1fc8d 
Signed-off-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
@root-expert @hdep
Drop Puppet 5/Add puppet 7 support
171bff7 
Signed-off-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
@hdep
Copy link
Contributor Author

hdep commented Aug 18, 2021

@root-expert I think we are good now ?

@root-expert
Copy link
Member

Yes! Let's wait for the tests. In the meantime, can you update the title to something more appropriate?

@hdep hdep changed the title WIP - Fix centos - HELP WANTED Fix centos Aug 18, 2021
@root-expert
Copy link
Member

This PR contains:

bastelfreak
bastelfreak reviewed Aug 18, 2021
View reviewed changes
manifests/mongos/service.pp
@@ -25,6 +26,13 @@
}

if $service_manage {
if $facts['os']['family'] == 'RedHat' {
systemd::unit_file { 'mongos.service':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we only manage it on redhat?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First My work was only to fix the module for RedHat. Secondly I think other distro has the needed file in the package.

@root-expert root-expert mentioned this pull request Aug 18, 2021
Merged
root-expert
root-expert reviewed Aug 19, 2021
View reviewed changes
manifests/globals.pp Show resolved Hide resolved
manifests/mongos.pp Outdated Show resolved Hide resolved
@root-expert root-expert added the bug Something isn't working label Aug 19, 2021
@root-expert root-expert changed the title Fix centos Fix MongoDB installation on RedHat family Aug 19, 2021
@hdep hdep closed this Aug 19, 2021
@hdep hdep reopened this Aug 19, 2021
@root-expert root-expert merged commit aa1a7ed into voxpupuli:master Aug 20, 2021
@hdep hdep mentioned this pull request Aug 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

@root-expert root-expert root-expert approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hdep @kenyon @oniGino @ZloeSabo @root-expert @bastelfreak @ekohl