Add mongo 5.0 debian / ubuntu apt key #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xepa
changed the title
attachmentgenie
approved these changes
Aug 2, 2021
kenyon
changed the title
|
hi @xepa , thanks for the PR. Can you add a unit test for this? |
1 similar comment
|
hi @xepa , thanks for the PR. Can you add a unit test for this? |
|
Hello! Can you rebase with our master branch? |
|
Can you instead perform a rebase instead of a merge commit? Also can you squash the rest of the commits? |
xepa
force-pushed
the
issue.upstream#614
branch
from
f5b7697
to
92491f9
Compare
|
Sorry for the late response I was on vacation, it was rebased and squashed. |
xepa
force-pushed
the
issue.upstream#614
branch
from
92491f9
to
8e90d14
Compare
|
I rebased again |
|
@xepa We need some acceptance tests to verify MongoDB 5.0 works as expected. |
xepa
force-pushed
the
issue.upstream#614
branch
from
8e90d14
to
4f02462
Compare
xepa
force-pushed
the
issue.upstream#614
branch
from
4f02462
to
9e5c471
Compare
|
I added some static unit tests for 26, 4 and 5 @root-expert if this is not what you were looking for please advise on how to proceed. Please note: I am a ruby newbie .. so any tips to improve the unit tests are welcome ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adds 5.0 apt key for debian/ubuntu mongo repo
This Pull Request (PR) fixes the following issues
Resolves #614