Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump systemd: < 7.0.0 #687

Merged
merged 3 commits into from
Jan 30, 2024
Merged

bump systemd: < 7.0.0 #687

merged 3 commits into from
Jan 30, 2024

Conversation

sandwitch
Copy link

Here is a pr for changing the max version of puppet-systemd to 6.0.0

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@kenyon
Copy link
Member

kenyon commented Nov 29, 2023

systemd is at v6.2.0, so the PR should do < 7.0.0. https://github.com/voxpupuli/puppet-systemd/blob/master/CHANGELOG.md

@kenyon kenyon changed the title bump systemd: < 6.0.0 bump systemd: < 7.0.0 Nov 29, 2023
@kenyon kenyon added the enhancement New feature or request label Nov 29, 2023
@kenyon
Copy link
Member

kenyon commented Nov 29, 2023

Looks like we need @traylenator's test fixes from #685 first.

@zilchms
Copy link
Contributor

zilchms commented Jan 29, 2024

@sandwitch can you rebase your PR on the current master? then i can merge this, once the CI is passing

@sandwitch
Copy link
Author

I'm relatively new to pull request. I have updated my fork:bump_systemd. Is it good to go like this?

@zilchms
Copy link
Contributor

zilchms commented Jan 30, 2024

Normally you would do something like this, after making sure every branch is up-to-date

git checkout <feature-branch>
git rebase master
git push --force

Then your branch is forwarded to the most recent change in master. But for this time I think its alright as it is :)
Thanks for your contribution :)

@zilchms zilchms merged commit af3345e into voxpupuli:master Jan 30, 2024
12 checks passed
@zilchms zilchms mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants