Support for pure yaml in is_master.rb #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenpost
reviewed
Apr 10, 2024
lib/facter/is_master.rb
Outdated
Comment on lines
13
to
18
| port = config['net.port'] | ||
| port = config.fetch('net', {}).fetch('port', nil) if port.nil? | ||
| ipv6 = config['net.ipv6'] | ||
| ipv6 = config.fetch('net', {}).fetch('ipv6', nil) if ipv6.nil? | ||
| tls_mode = config['net.tls.mode'] | ||
| tls_mode = config.fetch('net', {}).fetch('tls', {}).fetch('mode', nil) if tls_mode.nil? |
There was a problem hiding this comment.
Have a look at
I think that is the better way to support both formats, same effect, more compact code.
h-haaks
force-pushed
the
real-yaml-in-is_master-fact
branch
from
433300e
to
f315040
Compare
h-haaks
force-pushed
the
real-yaml-in-is_master-fact
branch
from
f315040
to
a521a9b
Compare
stevenpost
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
To be able to use pure yaml in mongod.conf the mongodb_is_master fact has to support both dot format and pure yaml formats.