Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always define module_dir variable #265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

briehman
Copy link
Contributor

Restore the definition of a blank module_dir that was removed in 33a8351 in order to prevent Puppet warnings about undeclared variables.

After attempting to use this module in a Puppet 4 environment, Puppet issues warnings about the missing variable such as:

==> fbstandalone: Warning: Unknown variable: 'module_dir'. at /tmp/vagrant-puppet/modules-6f8cfc5da5ac652a8bb050dde61d3361/wildfly/manifests/config/module.pp:29:46 ==> fbstandalone: Warning: Unknown variable: 'module_dir'. at /tmp/vagrant-puppet/modules-6f8cfc5da5ac652a8bb050dde61d3361/wildfly/manifests/config/module.pp:29:46

Restore the definition of a blank module_dir that was removed in
33a8351 in order to prevent Puppet warnings about undeclared variables.
@coveralls
Copy link

coveralls commented Dec 18, 2018

Coverage Status

Coverage increased (+0.5%) to 74.854% when pulling 44bc627 on briehman:always-define-module-dir into d9433d4 on biemond:master.

@jairojunior jairojunior closed this Oct 1, 2019
@jairojunior jairojunior reopened this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants